Skip to content

Drop, then add same column#404

Merged
shlomi-noach merged 6 commits intomasterfrom
drop-add-same-column
May 1, 2017
Merged

Drop, then add same column#404
shlomi-noach merged 6 commits intomasterfrom
drop-add-same-column

Conversation

@shlomi-noach
Copy link
Copy Markdown
Contributor

@shlomi-noach shlomi-noach commented Apr 23, 2017

fixes #384

A migration that runs drop column c, ..., add column c now understands the before-c and after-c are different columns, and does not attempt to copy c's data into the ghost table.

  • contributed code is using same conventions as original code
  • code is formatted via gofmt (please avoid goimports)
  • code is built via ./build.sh
  • code is tested via ./test.sh

cc @github/platform-data @ikewalker

@shlomi-noach shlomi-noach deployed to production/ghost-mysql001 April 23, 2017 17:45 Active
@shlomi-noach shlomi-noach changed the title Drop add same column Drop, then add same column Apr 23, 2017
@shlomi-noach shlomi-noach merged commit d757539 into master May 1, 2017
@shlomi-noach shlomi-noach deleted the drop-add-same-column branch May 1, 2017 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error 1048 dropping a NULL column and adding same named column back as NOT NULL in the same migration

1 participant