UPDATE on migration's unique key column data loss: fixing#520
Merged
shlomi-noach merged 7 commits intomasterfrom Nov 30, 2017
Merged
UPDATE on migration's unique key column data loss: fixing#520shlomi-noach merged 7 commits intomasterfrom
shlomi-noach merged 7 commits intomasterfrom
Conversation
Contributor
Author
|
At this stage |
Contributor
Author
|
3898d49 turns an Sending to testing. |
Contributor
Author
|
Tests are good in production. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #519
This work in progress PR is to tackle #519, where an update to the migration's iterating unique key column can result with data loss.
We will either:
updateis unsupported.We'll see how goes.
Initial commit: a test that reproduces the data loss.