Skip to content

Iniital CLI implementation#1

Merged
salvador-barboza merged 6 commits intomainfrom
chava/add-cli
Mar 20, 2025
Merged

Iniital CLI implementation#1
salvador-barboza merged 6 commits intomainfrom
chava/add-cli

Conversation

@salvador-barboza
Copy link
Copy Markdown
Collaborator

@salvador-barboza salvador-barboza commented Mar 18, 2025

https://github.com/github/spark/issues/327

This adds the initial version of the Runtime CLI, with support for

  • gh runtime get
  • gh runtime delete
  • gh runtime create
  • gh runtime deploy (with directory zipping)

Copilot AI review requested due to automatic review settings March 18, 2025 21:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Initial implementation of a CLI for GitHub Runtime management

  • Introduces a deploy command for deploying directories
  • Adds a delete command to remove GitHub Runtime apps
  • Establishes a root command for overall CLI execution and updates the main entry point

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

File Description
cmd/deploy.go Implements the deploy command with necessary flags
cmd/delete.go Implements the delete command with flag validation
cmd/root.go Adds a root command for the CLI
main.go Updates main to execute the new root command
Files not reviewed (1)
  • go.mod: Language not supported

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

Comment thread cmd/delete.go Outdated
Comment on lines +38 to +41
client, _ := gh.RESTClient(&api.ClientOptions{
// Log: os.Stderr,
})

Copy link

Copilot AI Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error returned by gh.RESTClient is ignored. Add error handling to ensure that the client is properly initialized.

Suggested change
client, _ := gh.RESTClient(&api.ClientOptions{
// Log: os.Stderr,
})
client, err := gh.RESTClient(&api.ClientOptions{
// Log: os.Stderr,
})
if err != nil {
fmt.Printf("Error initializing REST client: %v\n", err)
return
}

Copilot uses AI. Check for mistakes.
@salvador-barboza salvador-barboza merged commit 4a1f713 into main Mar 20, 2025
2 of 3 checks passed
@salvador-barboza salvador-barboza deleted the chava/add-cli branch September 2, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants