Iniital CLI implementation#1
Merged
salvador-barboza merged 6 commits intomainfrom Mar 20, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Initial implementation of a CLI for GitHub Runtime management
- Introduces a deploy command for deploying directories
- Adds a delete command to remove GitHub Runtime apps
- Establishes a root command for overall CLI execution and updates the main entry point
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/deploy.go | Implements the deploy command with necessary flags |
| cmd/delete.go | Implements the delete command with flag validation |
| cmd/root.go | Adds a root command for the CLI |
| main.go | Updates main to execute the new root command |
Files not reviewed (1)
- go.mod: Language not supported
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
Comment on lines
+38
to
+41
| client, _ := gh.RESTClient(&api.ClientOptions{ | ||
| // Log: os.Stderr, | ||
| }) | ||
|
|
There was a problem hiding this comment.
The error returned by gh.RESTClient is ignored. Add error handling to ensure that the client is properly initialized.
Suggested change
| client, _ := gh.RESTClient(&api.ClientOptions{ | |
| // Log: os.Stderr, | |
| }) | |
| client, err := gh.RESTClient(&api.ClientOptions{ | |
| // Log: os.Stderr, | |
| }) | |
| if err != nil { | |
| fmt.Printf("Error initializing REST client: %v\n", err) | |
| return | |
| } |
justinmcbride
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/github/spark/issues/327
This adds the initial version of the Runtime CLI, with support for