Skip to content

Display Default App URL on Get#4

Merged
justinmcbride merged 1 commit intomainfrom
justinmcbride/spark-235-get-url
Mar 29, 2025
Merged

Display Default App URL on Get#4
justinmcbride merged 1 commit intomainfrom
justinmcbride/spark-235-get-url

Conversation

@justinmcbride
Copy link
Copy Markdown
Collaborator

Copilot AI review requested due to automatic review settings March 29, 2025 05:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies how the CLI displays the default app URL by refactoring the command execution to use explicit exit codes and by returning errors from command functions.

  • Refactors main.go to capture and use the exit code returned by cmd.Execute.
  • Updates cmd/root.go to return a custom exitCode instead of calling os.Exit directly.
  • Changes cmd/get.go to return errors from its command function and prints the app URL from a structured response.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
main.go Updates main to capture exit codes from cmd.Execute.
cmd/root.go Refactors Execute() to return a custom exit code.
cmd/get.go Modifies the get command to return errors and display the default app URL.
Comments suppressed due to low confidence (1)

main.go:10

  • [nitpick] Consider renaming the variable 'code' to 'exitCode' to more clearly indicate that it represents the process exit code.
code := cmd.Execute()

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@justinmcbride justinmcbride merged commit d40f13a into main Mar 29, 2025
4 checks passed
@justinmcbride justinmcbride deleted the justinmcbride/spark-235-get-url branch March 29, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants