Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies how the CLI displays the default app URL by refactoring the command execution to use explicit exit codes and by returning errors from command functions.
- Refactors main.go to capture and use the exit code returned by cmd.Execute.
- Updates cmd/root.go to return a custom exitCode instead of calling os.Exit directly.
- Changes cmd/get.go to return errors from its command function and prints the app URL from a structured response.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| main.go | Updates main to capture exit codes from cmd.Execute. |
| cmd/root.go | Refactors Execute() to return a custom exit code. |
| cmd/get.go | Modifies the get command to return errors and display the default app URL. |
Comments suppressed due to low confidence (1)
main.go:10
- [nitpick] Consider renaming the variable 'code' to 'exitCode' to more clearly indicate that it represents the process exit code.
code := cmd.Execute()
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes https://github.com/github/spark/issues/235