Add new Revision Name Flags #5
Merged
alexagillman merged 3 commits intomainfrom May 5, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new revision_name flag to the deploy and create commands, allowing users to pass a revision identifier to dotcom APIs.
- Introduce
RevisionNamefield in command flag structs - Import
net/urland appendrevision_namequery parameter when provided - Update URL building for both deploy and create endpoints
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/deploy.go | Add RevisionName flag field and include it in the deployment URL |
| cmd/create.go | Add RevisionName flag field and include it in the creation URL |
Comments suppressed due to low confidence (2)
cmd/create.go:18
- The new
RevisionNamefield is never bound to a CLI flag. Add aStringVarorStringVarPcall ininit()(e.g.,createCmd.Flags().StringVar(&createCmdFlags.RevisionName, "revision-name", "", "revision name to send to the API")).
RevisionName string
cmd/deploy.go:136
- Consider adding unit tests for URL construction when
RevisionNameis set or unset to ensure the query parameter is encoded correctly.
if deployCmdFlags.RevisionName != "" {
justinmcbride
approved these changes
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For item: https://github.com/github/spark/issues/639, https://github.com/github/spark/issues/1449. Add new flags to pass revision name to dotcom APIs