Refactor event filtering logic and add filter config type #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the event filtering logic in the `eventFilter` function and introduces a new `FilterConfig` interface to define the structure of the filter configuration. The `eventFilter` function creation checks if the `filter_config` is undefined and always returns true if it is. It also removes some namespace imports and changes uses of `String` to `string`.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| export const eventFilter = (event: EmitterWebhookEvent): boolean => { | ||
| export const eventFilter = !validateFilterConfig(filter_config) ? (_: EmitterWebhookEvent) => true : (event: EmitterWebhookEvent): boolean => { |
Check failure
Code scanning / ESLint
Disallow unused variables
| } | ||
|
|
||
| if (filter_config.include === undefined && filter_config.exclude === undefined) { | ||
| console.error("Filter config has neither an include nor an exclude property"); |
Check failure
Code scanning / ESLint
disallow the use of `console`
| if (applyFilter(payload, exclude_filter, false)) return false; | ||
| function validateFilterConfig(config: FilterConfig | undefined): boolean { | ||
| if (config === undefined) { | ||
| console.error("Filter config is undefined"); |
Check failure
Code scanning / ESLint
disallow the use of `console`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the event filtering logic in the
eventFilterfunction and introduces a newFilterConfiginterface to define the structure of the filter configuration. TheeventFilterfunction creation checks if thefilter_configis undefined and always returns true if it is.It also removes some namespace imports and changes uses of
Stringtostring.