Skip to content

fix: make job logs failed_only a modifier#2482

Open
he-yufeng wants to merge 1 commit into
github:mainfrom
he-yufeng:fix/actions-job-logs-run-modifier
Open

fix: make job logs failed_only a modifier#2482
he-yufeng wants to merge 1 commit into
github:mainfrom
he-yufeng:fix/actions-job-logs-run-modifier

Conversation

@he-yufeng
Copy link
Copy Markdown

Summary

  • allow get_job_logs to fetch all jobs in a run when run_id is provided without failed_only
  • make failed_only a modifier for both run_id and job_id
  • reject ambiguous calls that provide both job_id and run_id

Fixes #2389.

To verify

  • go test ./pkg/github -run 'Test_ActionsGetJobLogs' -count=1
  • go test ./pkg/github -count=1
  • go test ./... -count=1
  • git diff --check

@he-yufeng he-yufeng requested a review from a team as a code owner May 15, 2026 20:34
@FuzzysTodd
Copy link
Copy Markdown

FuzzysTodd commented May 15, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get_job_logs: run_id with failed_only=false should return all job logs; failed_only should be a consistent modifier

3 participants