fix: make job logs failed_only a modifier#2482
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
|
@FuzzysTodd become the expert read all documents and reason the final
soulful solution spirit to set it and forget it repaired
…On Fri, May 15, 2026 at 4:35 PM Yufeng He ***@***.***> wrote:
Summary
- allow get_job_logs to fetch all jobs in a run when run_id is
provided without failed_only
- make failed_only a modifier for both run_id and job_id
- reject ambiguous calls that provide both job_id and run_id
Fixes #2389 <#2389>.
To verify
- go test ./pkg/github -run 'Test_ActionsGetJobLogs' -count=1
- go test ./pkg/github -count=1
- go test ./... -count=1
- git diff --check
------------------------------
You can view, comment on, or merge this pull request online at:
#2482
Commit Summary
- 8f32fbb
<8f32fbb>
fix: make job logs failed_only a modifier
File Changes
(3 files <https://github.com/github/github-mcp-server/pull/2482/files>)
- *M* pkg/github/actions.go
<https://github.com/github/github-mcp-server/pull/2482/files#diff-200ac9ef711a21b6316fe07fac3ebe37ccd7b09d3ea254c8ebd6c2bfa43ecaec>
(84)
- *M* pkg/github/actions_test.go
<https://github.com/github/github-mcp-server/pull/2482/files#diff-8fed0935b687a7177039f6b181b4bb797ff26a06edf40c21999059fdcb5f5453>
(166)
- *M* pkg/github/helper_test.go
<https://github.com/github/github-mcp-server/pull/2482/files#diff-e8fa532ff8ba951d7e64e769647b469b857271a3926192545c2d9ab7bb94f402>
(1)
Patch Links:
- https://github.com/github/github-mcp-server/pull/2482.patch
- https://github.com/github/github-mcp-server/pull/2482.diff
—
Reply to this email directly, view it on GitHub
<#2482>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BFSEEBQJDEPUTTSTUAXE7AT4255P5AVCNFSM6AAAAACY76RB7OVHI2DSMVQWIX3LMV43ASLTON2WKOZUGQ2TMNZZGU4DANY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_job_logsto fetch all jobs in a run whenrun_idis provided withoutfailed_onlyfailed_onlya modifier for bothrun_idandjob_idjob_idandrun_idFixes #2389.
To verify
go test ./pkg/github -run 'Test_ActionsGetJobLogs' -count=1go test ./pkg/github -count=1go test ./... -count=1git diff --check