Skip to content

I want to enable only ifc #2565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoannaaKL merged 2 commits into from
May 28, 2026
+4 −10
Merged

I want to enable only ifc #2565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db1edba
I want to enable only ifc
JoannaaKL May 28, 2026
855857e
Fix tests
JoannaaKL May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/github/feature_flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ const FeatureFlagIssueFields = "remote_mcp_issue_fields"
var AllowedFeatureFlags = []string{
MCPAppsFeatureFlag,
FeatureFlagCSVOutput,
FeatureFlagIFCLabels,
Comment thread
JoannaaKL marked this conversation as resolved.
FeatureFlagIssueFields,
FeatureFlagIssuesGranular,
FeatureFlagPullRequestsGranular,
Expand Down
7 changes: 3 additions & 4 deletions pkg/github/feature_flags_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ func TestResolveFeatureFlags(t *testing.T) {
name: "no features, no insiders",
enabledFeatures: nil,
expectedFlags: nil,
unexpectedFlags: []string{MCPAppsFeatureFlag, FeatureFlagIFCLabels},
unexpectedFlags: []string{MCPAppsFeatureFlag},
},
{
name: "explicit feature enabled",
Expand All @@ -168,10 +168,9 @@ func TestResolveFeatureFlags(t *testing.T) {
expectedFlags: []string{FeatureFlagIFCLabels},
},
{
name: "internal-only flags are not directly enabled",
name: "ifc_labels can be directly enabled",
enabledFeatures: []string{FeatureFlagIFCLabels},
expectedFlags: nil,
unexpectedFlags: []string{FeatureFlagIFCLabels},
expectedFlags: []string{FeatureFlagIFCLabels},
},
{
name: "unknown flags are filtered out",
Expand Down
6 changes: 0 additions & 6 deletions pkg/http/server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,6 @@ func TestCreateHTTPFeatureChecker(t *testing.T) {
headerFeatures: []string{github.FeatureFlagIssuesGranular},
wantEnabled: true,
},
{
name: "internal-only flag in header is ignored",
flagName: github.FeatureFlagIFCLabels,
headerFeatures: []string{github.FeatureFlagIFCLabels},
wantEnabled: false,
},
{
name: "static insiders enables insiders flags without route context",
staticInsiders: true,
Expand Down
Loading