This repository was archived by the owner on Jan 31, 2019. It is now read-only.
Conversation
The latest version relaxes the constraint on signet, which is blocking downstream dependencies for the hook delivery system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elsewhere in our stack, we need to use a gem that depends on
signet ~> 0.7, but themaxcdngem dependency here is pinned tosignet ~> 0.5.1. This PR updates the maxcdn gem to the latest version, which relaxes the signet dependency to~> 0.7.The client API itself hasn't changed at all: diff, although the http client it uses under the hood has changed from curb/curb-fu to net-http-persistent with faraday. This shouldn't present any compatibility issues with hook delivery to maxcdn.