Skip to content

Replaced snap install#72

Merged
KittyChiu merged 3 commits into
mainfrom
fix/snap-instal
May 6, 2026
Merged

Replaced snap install#72
KittyChiu merged 3 commits into
mainfrom
fix/snap-instal

Conversation

@KittyChiu
Copy link
Copy Markdown
Collaborator

This pull request updates the way Dart Sass is installed in the .github/workflows/pr-check.yml workflow. Instead of using snap, it now downloads a specific version (1.99.0) directly from GitHub and installs it manually. This change improves reliability and ensures consistent versioning across environments.

Copilot AI review requested due to automatic review settings May 4, 2026 05:53
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

This comment was marked as outdated.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment thread .github/workflows/pr-check.yml
@KittyChiu KittyChiu changed the title Replaced snap install with curl Replaced snap install May 4, 2026
@KittyChiu KittyChiu enabled auto-merge (squash) May 4, 2026 06:59
@KittyChiu KittyChiu self-assigned this May 4, 2026
Copy link
Copy Markdown

@dkalmin dkalmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good I verified this installs DART correctly.

@well-architected-sync-bot
Copy link
Copy Markdown
Contributor

✅ Site Deployment Request Submitted

A request for live site deployment has been submitted.

Next Steps

  1. GitHub site maintainers will review your request shortly.
  2. Once approved, the changes will be deployed to the GitHub Well-Architected live site.
  3. This PR will be merged once the deployment is successful.

Note: If this contribution involves collaboration with GitHub, please contact your GitHub representative to help expedite the deployment process.


Internal xref: https://github.com/github/github-well-architected-internal/pull/1193

@well-architected-oss-bot well-architected-oss-bot Bot deployed to staging May 5, 2026 15:57 Active
@well-architected-sync-bot
Copy link
Copy Markdown
Contributor

✅ Site Deployment Request Submitted

A request for live site deployment has been submitted.

Next Steps

  1. GitHub site maintainers will review your request shortly.
  2. Once approved, the changes will be deployed to the GitHub Well-Architected live site.
  3. This PR will be merged once the deployment is successful.

Note: If this contribution involves collaboration with GitHub, please contact your GitHub representative to help expedite the deployment process.


Internal xref:

@KittyChiu KittyChiu disabled auto-merge May 6, 2026 00:22
@KittyChiu KittyChiu marked this pull request as draft May 6, 2026 01:44
@github-actions github-actions Bot added draft PR is in draft and removed ready for review labels May 6, 2026
@KittyChiu KittyChiu marked this pull request as ready for review May 6, 2026 08:15
@github-actions github-actions Bot added ready for review and removed draft PR is in draft labels May 6, 2026
@KittyChiu KittyChiu merged commit 1209e63 into main May 6, 2026
26 checks passed
@KittyChiu KittyChiu deleted the fix/snap-instal branch May 6, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants