Skip to content

Add spool folder to Symfony#1452

Merged
shiftkey merged 1 commit intogithub:masterfrom
nunorafaelrocha:enhancement/add-spool-folder
Mar 6, 2016
Merged

Add spool folder to Symfony#1452
shiftkey merged 1 commit intogithub:masterfrom
nunorafaelrocha:enhancement/add-spool-folder

Conversation

@nunorafaelrocha
Copy link
Copy Markdown

Reasons for making this change:

As stated in Symfony documentation, all " log and cache files and dumped assets (which are created automatically by your project), should not be committed in Git.". Spool folder only contains files created by running the application, since they are files to be sent.

Links to documentation supporting these rule changes:

http://symfony.com/doc/current/cookbook/workflow/new_project_git.html

@shiftkey
Copy link
Copy Markdown
Member

@nunorafaelrocha Is there any supporting links you can give which explain what this file represents and why it can be safely ignored from version control?

@nunorafaelrocha
Copy link
Copy Markdown
Author

@shiftkey Updated PR description to add the necessary information.

@shiftkey
Copy link
Copy Markdown
Member

shiftkey commented Mar 6, 2016

@nunorafaelrocha fantastic, thanks!

shiftkey added a commit that referenced this pull request Mar 6, 2016
@shiftkey shiftkey merged commit 028ed4e into github:master Mar 6, 2016
u9E9F pushed a commit to u9E9F/gitignore that referenced this pull request Jul 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants