Skip to content

Dartdoc output directory, pubspec.lock comment disambiguation #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shiftkey merged 4 commits into from
Oct 11, 2015
Merged

Dartdoc output directory, pubspec.lock comment disambiguation #1690

shiftkey merged 4 commits into from
Oct 11, 2015

Conversation

@ArgentiApparatus
Copy link
Contributor

@ArgentiApparatus ArgentiApparatus commented Oct 8, 2015

  1. Added directory for output of dartdoc tool.
  2. Made style of comment for the pubspec.lock pattern consistent with others and disambiguated it.

@ArgentiApparatus
Dartdoc, pubspec.lock disabiguation
b14da8f 
Added directory for dartdoc tool. Disambiguated comment for pubspec.lock
pattern.
shiftkey
shiftkey reviewed Oct 8, 2015
View reviewed changes
Dart.gitignore Outdated
Copy link
Member

@shiftkey shiftkey Oct 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💄 drop this whitespace

@ArgentiApparatus
Copy link
Contributor Author

ArgentiApparatus commented Oct 8, 2015

I don't think I added whitespace to line 1, I'm really not sure why GitHub thinks that line is changed.

@ArgentiApparatus
Fix line 1
d0f5047 
Line 1 somehow different from upstream
@ArgentiApparatus
Copy link
Contributor Author

ArgentiApparatus commented Oct 10, 2015

I believe issue with line 1 is now fixed.

@shiftkey
Copy link
Member

shiftkey commented Oct 11, 2015

Thanks!

shiftkey added a commit that referenced this pull request Oct 11, 2015
@shiftkey
Merge pull request #1690 from ArgentiApparatus/master
a5acbc2 
Dartdoc output directory, pubspec.lock comment disambiguation
@shiftkey shiftkey merged commit a5acbc2 into github:master Oct 11, 2015
u9E9F pushed a commit to u9E9F/gitignore that referenced this pull request Jul 8, 2017
@shiftkey
Merge pull request github#1690 from ArgentiApparatus/master
a700bff 
Dartdoc output directory, pubspec.lock comment disambiguation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ArgentiApparatus @shiftkey