Remove ApplicationInsights.config from VisualStudio.gitignore#1889
Merged
shiftkey merged 1 commit intogithub:masterfrom Mar 4, 2016
Merged
Remove ApplicationInsights.config from VisualStudio.gitignore#1889shiftkey merged 1 commit intogithub:masterfrom
shiftkey merged 1 commit intogithub:masterfrom
Conversation
Commit a25589c introduced an ignore line for ApplicationInsights.config. This change breaks builds on certain systems, namely VSTS. The current ASP.NET 4 template adds ApplicationInsights.config to the project's .csproj file. When VSTS attempts to build the project, it will fail if it cannot find ApplicationInsights.config. ApplicationInsights.config is a required application file and should not be ignored.
Member
|
@aholmes thanks for this! |
shiftkey
added a commit
that referenced
this pull request
Mar 4, 2016
Remove ApplicationInsights.config from VisualStudio.gitignore
Author
|
And thank you! |
u9E9F
pushed a commit
to u9E9F/gitignore
that referenced
this pull request
Jul 8, 2017
Remove ApplicationInsights.config from VisualStudio.gitignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for making this change:
Commit a25589c introduced an ignore line for ApplicationInsights.config. This change breaks builds on certain systems, namely VSTS.
The current ASP.NET 4 template adds ApplicationInsights.config to the project's .csproj file. When VSTS attempts to build the project, it will fail if it cannot find ApplicationInsights.config.
ApplicationInsights.config is a required application file and should not be ignored.
Links to documentation supporting these rule changes:
https://azure.microsoft.com/en-us/documentation/articles/app-insights-start-monitoring-app-health-usage/#ide