Skip to content

Conversation

@jamesqo
Copy link
Contributor

@jamesqo jamesqo commented Jul 30, 2017

Reasons for making this change:

I search my GitHub repo regularly for the string "TODO" and this always shows up. Please consider removing the todo; I'm also open to changing it to something else like Note: .

@shiftkey
Copy link
Member

@jamesqo good point!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to some other prefix here. I'm not really sure if there's a better way here to indicate that you can introduce an optional rule here, but Note: is a fine substitute.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I went with Note: .

@shiftkey
Copy link
Member

@jamesqo thanks!

@shiftkey shiftkey merged commit ab47781 into github:master Jul 31, 2017
@jamesqo jamesqo deleted the patch-1 branch July 31, 2017 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants