Skip to content

Packer template - Exclude .pkrvars.hcl files#3514

Merged
bdougie merged 3 commits intogithub:mainfrom
tlindsay42:packer-pkrvars.hcl
Jan 30, 2022
Merged

Packer template - Exclude .pkrvars.hcl files#3514
bdougie merged 3 commits intogithub:mainfrom
tlindsay42:packer-pkrvars.hcl

Conversation

@tlindsay42
Copy link
Copy Markdown
Contributor

Reasons for making this change:

Starting from version 1.5.0, Packer supports HCL2 definition files. These files serve the same purpose as Terraform .tfvars files, which persist variable values and are likely to contain sensitive data such as password, private keys, and other secrets.

Citation

We don't recommend saving usernames and password to version control, but you can create a local secret variables file and use -var-file to load it.

Links to documentation supporting these rule changes:

* Used description for .tfvars in Terraform.gitignore as a template
s/sentitive/sensitive/
@tlindsay42
Copy link
Copy Markdown
Contributor Author

Ready for review @shiftkey

@tlindsay42
Copy link
Copy Markdown
Contributor Author

@53jk1, do you have sufficient access to merge? I don't. ?

Or @bdougie?

@kbakdev
Copy link
Copy Markdown

kbakdev commented Jan 30, 2022

No, I haven't

@bdougie bdougie merged commit 821f001 into github:main Jan 30, 2022
@tlindsay42 tlindsay42 deleted the packer-pkrvars.hcl branch January 31, 2022 01:18
@tlindsay42
Copy link
Copy Markdown
Contributor Author

Thanks @53jk1 & @bdougie!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants