Fix errors causing build to fail the rubocop checks.#725
Merged
jbjonesjr merged 2 commits intogithub:gh-pagesfrom Oct 23, 2018
thomasgohard:fix-build
Merged
Fix errors causing build to fail the rubocop checks.#725jbjonesjr merged 2 commits intogithub:gh-pagesfrom thomasgohard:fix-build
jbjonesjr merged 2 commits intogithub:gh-pagesfrom
thomasgohard:fix-build
Conversation
Collaborator
|
this is true. thanks @thomasgohard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is causing all PRs to fail since #715. Currently affects PRs #715, #717, #718, #720, #721, #722, #723, and #724.
The root cause is likely rubocop/rubocop#6235, which turned on a check that used to be disabled by default.