Skip to content

try using GITHUB_TOKEN in CI and obtaining fewer 429s etc?#970

Merged
mlinksva merged 8 commits intogh-pagesfrom
token
Jan 8, 2023
Merged

try using GITHUB_TOKEN in CI and obtaining fewer 429s etc?#970
mlinksva merged 8 commits intogh-pagesfrom
token

Conversation

@mlinksva
Copy link
Copy Markdown
Contributor

@mlinksva mlinksva commented Jan 7, 2023

No description provided.

@mlinksva mlinksva closed this Jan 7, 2023
@mlinksva mlinksva reopened this Jan 7, 2023
@nschonni
Copy link
Copy Markdown
Contributor

nschonni commented Jan 7, 2023

Probably need to do this in the scripts too

@mlinksva
Copy link
Copy Markdown
Contributor Author

mlinksva commented Jan 7, 2023

Yeah, will add elsewhere if/when this works.

Comment thread Rakefile Outdated
Comment thread Rakefile Outdated
@mlinksva
Copy link
Copy Markdown
Contributor Author

mlinksva commented Jan 8, 2023

Mysteries:

  • obviously not avoiding 429
  • htmlproofer config should ingore them (updated htmlproofer config for new version)
  • Not sure why 2 workflows aren't running (they only run if changes in _data, by design!)

@nschonni
Copy link
Copy Markdown
Contributor

nschonni commented Jan 8, 2023

Other approach might be to try getting it working on one of the other scripts with the native Typeous config, then use that for HTMLProofer https://github.com/gjtorikian/html-proofer/wiki/How-to-configure-Typhoeus

…9cec1f8d670bf16e6fa/UPGRADING.md?plain=1#L17
dont' check external hashes due to fedramp site using them for js without including in html
@mlinksva
Copy link
Copy Markdown
Contributor Author

mlinksva commented Jan 8, 2023

Not clear to me passing token is working, but other fixes here useful. Tests pass for 1st time in awhile.

@mlinksva mlinksva merged commit 3c908ed into gh-pages Jan 8, 2023
@mlinksva mlinksva deleted the token branch January 8, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants