AWS: Cannot read property 'item' of undefined

[devdazed]

When running hubot ec2 status the application crashes with this stack trace:

/home/scripts/hubot/node_modules/hubot-scripts/src/scripts/aws.coffee:94
            tags = _.flatten([instance.tagSet.item]);
                                             ^
TypeError: Cannot read property 'item' of undefined
    at /home/scripts/hubot/node_modules/hubot-scripts/src/scripts/aws.coffee:94:46
    at /home/scripts/hubot/node_modules/hubot-scripts/src/scripts/aws.coffee:99:12
    at /home/scripts/hubot/node_modules/aws2js/lib/internals.js:146:6
    at /home/scripts/hubot/node_modules/aws2js/node_modules/libxml-to-js/lib/libxml-to-js.js:178:3
    at /home/scripts/hubot/node_modules/aws2js/lib/internals.js:132:4
    at IncomingMessage.<anonymous> (/home/scripts/hubot/node_modules/aws2js/lib/internals.js:206:8)
    at IncomingMessage.emit (events.js:88:20)
    at HTTPParser.onMessageComplete (http.js:137:23)
    at CleartextStream.ondata (http.js:1150:24)
    at CleartextStream._push (tls.js:375:27)

[cerw]

I have same issue.

[technicalpickles]

Confirmed this. It looks like the instance being iterated over doesn't have a tagSet, for whatever reason.

/cc @Iristyle

[Iristyle]

Oh hey -- I made that ;0

That's pretty peculiar actually -- this would mean that your EC2 instance doesn't have tag metadata.

Whenever you new up an instance with ec2-run-instances, you get one tag by default IIRC, name

So could you tell me if you have instances without tag metadata?

I could certainly mod the code to not scrape the name of the instance out if the tagSet is null -- seems odd though.

[technicalpickles]

Thanks! Yeah, for my instances, there was no tag metadata. I'm not too savvy on EC2 things, but this might be an old old instance that doesn't have that.

Either way, it looks like it's definitely possible to not have a name tag. Maybe fall back to instanceId if it's not present?

[Iristyle]

Take a look at the proposed change.

I just slapped this together in Ace, as I don't have my Hubot install handy right now. Could you try it out locally?

Iristyle@875ec6f

[Iristyle]

@devdazed you want to give this a shot too? @cerw said this is a go for him.

If I had seen this sooner, I would have been on it.. but I don't monitor the bugtracker over here -- thanks @technicalpickles for bringing me in to the fold.

[Iristyle]

@devdazed you can close this...