Add flow declaration file #17
Conversation
|
|
||
| connectedCallback() { | ||
| if (this.constructed) return | ||
| this.constructed = true |
There was a problem hiding this comment.
@muan I just removed this, not sure what this was doing 😬
There was a problem hiding this comment.
This was preventing the template from being appended every time connectedCallback is triggered since we can't add nodes to the element in constructor.
This can potentially check for existence of .crop-wrapper within the node instead. However we should probably also convert these classes to data attributes and update the CSS accordingly since these classes could conflict with the host app.
There was a problem hiding this comment.
This was preventing the template from being appended every time
connectedCallbackis triggered since we can't add nodes to the element in constructor.
Cool! I just pushed a commit that checks a WeakMap for the element and returns if it has added the template already.
This can potentially check for existence of
.crop-wrapperwithin the node instead. However we should probably also convert these classes to data attributes and update the CSS accordingly since these classes could conflict with the host app.
Would it be cool if I did this in a follow up?
|
|
||
| connectedCallback() { | ||
| if (this.constructed) return | ||
| this.constructed = true |
There was a problem hiding this comment.
This was preventing the template from being appended every time connectedCallback is triggered since we can't add nodes to the element in constructor.
This can potentially check for existence of .crop-wrapper within the node instead. However we should probably also convert these classes to data attributes and update the CSS accordingly since these classes could conflict with the host app.
| target.dispatchEvent(new CustomEvent('image-crop-change', {bubbles: true, detail: result})) | ||
| } | ||
|
|
||
| export class ImageCropElement extends HTMLElement { |
There was a problem hiding this comment.
Is the a reason the class is no longer exported?
There was a problem hiding this comment.
It's exported as default at the end of this file so I removed this named export.
Store els in constrcutedElements
Add flow declaration file and some minor refactoring.