Revert JavaScript back to its old color

[anaisbetts]

Literally the entire Internet thinks these colors are too much:

https://twitter.com/passy/status/459364845830152193
https://twitter.com/chr_montgomery/status/459344416713744384
https://twitter.com/stev4niTy/status/459330521768534017
https://twitter.com/esorribas/status/459235930118029313
https://twitter.com/ThomSeddon/status/459235150917033984
https://twitter.com/wlaurance/status/459104364129710080
https://twitter.com/danielstjules/status/459084348977721344
https://twitter.com/engrishsmitelli/status/459077518176563200
https://twitter.com/smitelli/status/459077305655365633

[shiftkey]

Seems legit. Anyone wanna second this?

[dannygreg]

👍 do we need to ping anyone in particular? @josh perhaps?

[arfon]

I'm 👎 on reverting this. I thought this PR was pretty well thought through. Also, @paulcbetts you've linked to a bunch of tweets, not all of those are negative.

[josh]

The color change threw me off too, but I'll fully support @mdo's approval.

#979 seems pretty well thought through.

[mdo]

The problem with the color is it's intensity next to other colors. I don't think we need to 100% revert it, but the saturation or vibrancy (? I dunno the specific color terms here) needs to be tuned down.

Excuse the long number of line breaks now, but I want to visually separate the next set of screenshots for folks.

For example, changing the JS color in those same screenshots to #f1e05a looks like this now:

[anaisbetts]

I'm 👎 on reverting this. I thought this PR was pretty well thought through.

I mean, I would agree that it's thought-through, but I would also posit that something must have been incorrect in that thought process because our feedback is primarily (though not exclusively) negative.

Picking the "Official JavaScript Yellow" doesn't match with the rest of the page. There was a specific algorithm for choosing these colors, if you want to make JS yellow, you need to find the nearest matching color from that set.

/cc @github/design

[muan]

I'm with @mdo on this. I've been wondering if we made the language bar taller because it's grabbing a lot more attention, then realized it was the color. I'd prefer not reverting, but changing it to @mdo's suggestion.

[mdo]

Alternatively, switch the original JS color to be another language and make the JS one yellow, but setting a precedence for that isn't super helpful.

If the goal at large is to have colors for languages, I say we revert and deal with the (randomly?) chosen original colors.

If the goal at large is to have meaningful or unofficial colors for languages, let's work out a way to apply some color theory to this and pick a JS-y yellow that fits with all our other colors.

I know nothing about the latter, but I'm sure someone else does.

[arfon]

There was a specific algorithm for choosing these colors, if you want to make JS yellow, you need to find the nearest matching color from that set.

To be honest I don't feel incredibly strongly either way 😕 . I agree the yellow may be rather too vibrant and this ^^ is a good point @paulcbetts. The last thing I want is for people to find looking at a repo an unpleasant experience.

Given that @maxogden was the author of #979 I feel like we should invite him to defend his PR 😄

Also, @mdo you're suggestion for #f1e05a looks much better to my eyes.

[max-mapper]

If you do a twitter search for 'github yellow' you'll find no overwhelming support either way, people equally love it or dislike it.

Most of the negative feedback seems to be from people with (perhaps) really high brightness monitors who complain that the yellow is too jarring. I'm +1 on changing to #f1e05a for this reason.

[anaisbetts]

I'm okay with the darker version, lemme reset this PR and rig it to use #f1e05a instead

[arfon]

Fixed in #1135