New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert JavaScript back to its old color #1126

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
8 participants

@paulcbetts paulcbetts changed the title from Return to sanity to Revert JavaScript back to its old color Apr 25, 2014

@shiftkey

This comment has been minimized.

Member

shiftkey commented Apr 25, 2014

Seems legit. Anyone wanna second this?

@dannygreg

This comment has been minimized.

dannygreg commented Apr 25, 2014

👍 do we need to ping anyone in particular? @josh perhaps?

@arfon

This comment has been minimized.

Contributor

arfon commented Apr 25, 2014

I'm 👎 on reverting this. I thought this PR was pretty well thought through. Also, @paulcbetts you've linked to a bunch of tweets, not all of those are negative.

@josh

This comment has been minimized.

Member

josh commented Apr 25, 2014

The color change threw me off too, but I'll fully support @mdo's approval.

#979 seems pretty well thought through.

@mdo

This comment has been minimized.

Member

mdo commented Apr 25, 2014

The problem with the color is it's intensity next to other colors. I don't think we need to 100% revert it, but the saturation or vibrancy (? I dunno the specific color terms here) needs to be tuned down.

screen shot 2014-04-25 at 8 36 15 am
screen shot 2014-04-25 at 8 36 39 am
screen shot 2014-04-25 at 8 36 46 am
screen shot 2014-04-25 at 8 37 57 am

Excuse the long number of line breaks now, but I want to visually separate the next set of screenshots for folks.















For example, changing the JS color in those same screenshots to #f1e05a looks like this now:

screen shot 2014-04-25 at 8 38 59 am
screen shot 2014-04-25 at 8 39 06 am
screen shot 2014-04-25 at 8 39 12 am
screen shot 2014-04-25 at 8 39 18 am

@paulcbetts

This comment has been minimized.

Contributor

paulcbetts commented Apr 25, 2014

I'm 👎 on reverting this. I thought this PR was pretty well thought through.

I mean, I would agree that it's thought-through, but I would also posit that something must have been incorrect in that thought process because our feedback is primarily (though not exclusively) negative.

Picking the "Official JavaScript Yellow" doesn't match with the rest of the page. There was a specific algorithm for choosing these colors, if you want to make JS yellow, you need to find the nearest matching color from that set.

/cc @github/design

@muan

This comment has been minimized.

Member

muan commented Apr 25, 2014

I'm with @mdo on this. I've been wondering if we made the language bar taller because it's grabbing a lot more attention, then realized it was the color. I'd prefer not reverting, but changing it to @mdo's suggestion.

@mdo

This comment has been minimized.

Member

mdo commented Apr 25, 2014

Alternatively, switch the original JS color to be another language and make the JS one yellow, but setting a precedence for that isn't super helpful.

If the goal at large is to have colors for languages, I say we revert and deal with the (randomly?) chosen original colors.

If the goal at large is to have meaningful or unofficial colors for languages, let's work out a way to apply some color theory to this and pick a JS-y yellow that fits with all our other colors.

I know nothing about the latter, but I'm sure someone else does.

@arfon

This comment has been minimized.

Contributor

arfon commented Apr 25, 2014

There was a specific algorithm for choosing these colors, if you want to make JS yellow, you need to find the nearest matching color from that set.

To be honest I don't feel incredibly strongly either way 😕 . I agree the yellow may be rather too vibrant and this ^^ is a good point @paulcbetts. The last thing I want is for people to find looking at a repo an unpleasant experience.

Given that @maxogden was the author of #979 I feel like we should invite him to defend his PR 😄

Also, @mdo you're suggestion for #f1e05a looks much better to my eyes.

@maxogden

This comment has been minimized.

Contributor

maxogden commented Apr 25, 2014

If you do a twitter search for 'github yellow' you'll find no overwhelming support either way, people equally love it or dislike it.

Most of the negative feedback seems to be from people with (perhaps) really high brightness monitors who complain that the yellow is too jarring. I'm +1 on changing to #f1e05a for this reason.

@paulcbetts

This comment has been minimized.

Contributor

paulcbetts commented Apr 25, 2014

I'm okay with the darker version, lemme reset this PR and rig it to use #f1e05a instead

@arfon

This comment has been minimized.

Contributor

arfon commented Apr 27, 2014

Fixed in #1135

@arfon arfon closed this Apr 27, 2014

@paulcbetts paulcbetts deleted the return-to-sanity branch May 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment