allow multiple files for command line tool#884
Merged
kivikakk merged 2 commits intogithub:masterfrom Mar 19, 2017
oklas:cli-multi-files
Merged
allow multiple files for command line tool#884kivikakk merged 2 commits intogithub:masterfrom oklas:cli-multi-files
kivikakk merged 2 commits intogithub:masterfrom
oklas:cli-multi-files
Conversation
useful for prepare for printing multiple documents: github-markup repo/docs/* instead of echo repo/docs/* | xargs github-markup
kivikakk
suggested changes
Mar 16, 2017
bin/github-markup
Outdated
| file = File.open( s, "r" ) | ||
| sources.push [ s, file ] | ||
| rescue Exception => e | ||
| print "error: #{e.message}\n" |
Contributor
There was a problem hiding this comment.
I think it would be acceptable to print this to STDERR then exit with an error code. Currently this will go straight to STDOUT with the result of the output of the command.
bin/github-markup
Outdated
| } | ||
|
|
||
| sources.each { |s| | ||
| name,file = s |
Contributor
There was a problem hiding this comment.
Consider this form instead:
sources.each { |name, file|
Contributor
Author
There was a problem hiding this comment.
@kivikakk, advices are implemented, thanks
bin/github-markup
Outdated
| puts "usage: #$0 FILE" | ||
| if ARGV.size < 1 | ||
| print "usage: #$0 FILE [ FILES ... ]\n" | ||
| exit |
kivikakk
approved these changes
Mar 19, 2017
Contributor
|
Thank you! ✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useful for prepare for printing multiple documents:
github-markup repo/docs/*
instead of
echo repo/docs/* | xargs github-markup