site-maven-plugin: how to ignore proxy when uploading to a github enterprise instance ?

[cthiebaud]

I need to upload a maven site to my company's github enterprise instance.
My company is behind a proxy, and this proxy is is defined in maven settings.xml.

The problem is, if a proxy is defined in settings.xml, then site-maven-plugin uses it, although it must not when uploading to my company's github enterprise instance.

There should be a way to ignore it. I suggest that if the serverId is defined, and no proxy is found, then no proxy is used. Currently, if the serverId is defined, and no proxy is found, the first active proxy is returned.

[kkkon]

I'm sorry @cthiebaud
I forget github enterprise.

I made pull request.
This pull request expect settings.xml

  <proxies>
    <proxy>
      <id>for_external</id>
      <active>true</active>
      <protocol>http</protocol>
      <host>aaa.bbb.ccc.ddd</host>
      <port>nnn</port>
    </proxy>
    <proxy>
      <id>intra-github</id> <!-- serverId ${github.site.server} -->
      <active>true</active>
      <protocol>http</protocol>
      <host>127.0.0.1</host>
      <port>nnn</port>
      <nonProxyHosts>*</nonProxyHosts>
    </proxy>
  </proxies>

or

  <proxies>
    <proxy>
      <id>for_external</id>
      <active>true</active>
      <protocol>http</protocol>
      <host>aaa.bbb.ccc.ddd</host>
      <port>nnn</port>
      <nonProxyHosts>YOUR INTRA GITHUB ENTERPRISE</nonProxyHosts> <!-- ${github.site.host} -->
    </proxy>
  </proxies>