Conversation
added 2 commits
October 19, 2016 10:12
…pare-environments-production
ross
approved these changes
Oct 19, 2016
ross
left a comment
ross
left a comment
There was a problem hiding this comment.
Seems reasonable. One small questions/suggestion about a comment inline.
| # there is on-demand, explicit error checking for each file within the modification loop. | ||
| return unless compilation_dir.is_a?(String) && compilation_dir != '' | ||
|
|
||
| # Making sure that compilation_dir/environments/production exists. Otherwise, try to find |
There was a problem hiding this comment.
Seems like this is actually making sure that <compilation_dir>/environments/production/modules exists. The part below includes the /modules. Unless it's intention, they should probably match up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request avoids an exception being thrown when:
.environments/productionsymlink is missingThe changed code checks additional paths, and skips the code that will be problematic when the Puppet repository is not set up as expected.
Checklist
rakein your checkout directory, or review the CI job triggered whenever you push to a pull request.rake coverage:specor ignoring untestable sections of code with# :nocovcomments. If you need help getting to 100% coverage please ask; however, don't just submit code with no tests.