Ignore any kill errors for the testing SSL server#2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request ignores the
#<Errno::ESRCH: No such process>exception that's being thrown on Travis CI, during the portion of the test that is attempting to kill that process. If the process is already dead, it's fine if we can't kill it.It also adds a retry around starting the SSL server for some of the integration tests, so that a failure to start the test server has less of a change of failing the job. This seems to be an issue specific to Travis CI and it's intermittent.
Checklist
rakein your checkout directory, or review the CI job triggered whenever you push to a pull request.