Use diff object from API internally #55

merged 9 commits into from Jan 10, 2017


None yet

1 participant


This pull request changes the CLI class to use the catalog-diff API (and specifically the Diff object) instead of the raw objects. This is done mostly for dog-fooding of the API.

kpaulisse added some commits Jan 9, 2017
@kpaulisse kpaulisse Switch from raw diff object to API diff object e569ea9
@kpaulisse kpaulisse Update YAML integration to use `diff_match?` check 28d3231
@kpaulisse kpaulisse Update test to use `.diff_match?` 1c1c507
@kpaulisse kpaulisse Fix more tests to use `.diff_match?` f47c864
@kpaulisse kpaulisse Convert more integration tests to `.diff_match?` afd4d9c
@kpaulisse kpaulisse Convert more integration tests to `.diff_match?` 900ecb4
@kpaulisse kpaulisse Ignore errors from directory cleanup 816b2ea
@kpaulisse kpaulisse No test coverage of the remove_entry_secure issue
@kpaulisse kpaulisse changed the base branch to kpaulisse-release-0-7 from master Jan 9, 2017
@kpaulisse kpaulisse Merge branch 'kpaulisse-release-0-7' into kpaulisse-diff-api-use-inte…
@kpaulisse kpaulisse merged commit 1c2072f into kpaulisse-release-0-7 Jan 10, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
@kpaulisse kpaulisse deleted the kpaulisse-diff-api-use-internally branch Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment