Update documentation and examples for puppetdb SSL settings#9
Merged
Update documentation and examples for puppetdb SSL settings#9
Conversation
|
yes, this update to the documentation looks good. It would have helped |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request updates the example configuration file and the documentation pertaining to PuppetDB SSL client authentication. The example file was missing
File.read(...)around the paths, since the program internally expects the text of the key/certificate and not just the path to it. I've also added a link back to the Puppet documentation for the certificate whitelisting stuff.Fixes #6
/cc @jamesandrews-iopp who reported the original issue. Would this have made your experience more straightforward, or do you have suggestions to improve this?