Adding missing emojis and correcting typo #1164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
reviewed
Oct 31, 2019
docs/styleguide.md
Outdated
| * **Curation:** Amplify community best practices vs. any individual's point of view | ||
| * :smile: **Approachability:** Don't assume reader has prior knowledge | ||
| * :smile: **Brevity:** Keep it simple, link to outside content for deeper dives | ||
| * :cry: **Curation:** Amplify community best practices vs. any individual's point of view |
Contributor
There was a problem hiding this comment.
Can you remove these? Thanks!
| Completing an initial translation of the whole site is a fairly large task. One way to break that task up is to work with other translators through pull requests on your fork. Example: [pull requests on fork for German translation](https://github.com/katrinleinweber/opensource.guide/pulls?q=is%3Apr+is%3Aclosed) and corresponding [initial pull request for German translation](https://github.com/github/opensource.guide/pull/577) on this repository. | ||
|
|
||
| ## Updatng a translation | ||
| ## Updating a translation |
Contributor
Author
|
@MikeMcQuaid should i open another pR for second change of typo |
Contributor
|
@mohitm15 Please push another commit to this PR instead. Thanks! |
Contributor
Author
Please review the pr now @MikeMcQuaid |
MikeMcQuaid
approved these changes
Nov 4, 2019
Contributor
|
Thanks so much for your contribution! Without people like you submitting PRs we couldn't run this project. You rock, @mohitm15! |
Contributor
Author
your welcome @MikeMcQuaid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding missing emojis in styleguide.md and correcting the typo in translations.md
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.