Skip to content

Conversation

@katrinleinweber
Copy link
Contributor

  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


This updates all http-hyperlinks to https unless a browser warning was displayed when I tried loading the https version of the site. I consider this to fall under the contribution type "Fix editorial inconsistencies" ;-)

@katrinleinweber
Copy link
Contributor Author

katrinleinweber commented Oct 30, 2018

If anyone knows a bot that can do such tasks, please let me know. Effectively: a combination of html-proofer with HTTPS Everywhere or smart-HTTPS and a PR-capable bot?!?

Copy link
Contributor

@mlinksva mlinksva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've also idly wished for a script to do http->https in source files where https is available.

Finally, sometimes open source projects put bounties on issues that you might consider helping with.

* @ConnorChristie was able to get paid for [helping](https://github.com/MARKETProtocol/MARKET.js/issues/14) @MARKETProtocol work on their javascript library [through a bounty on gitcoin](https://gitcoin.co/).
* @ConnorChristie was able to get paid for [helping](https://web.archive.org/web/20181030123412/https://webcache.googleusercontent.com/search?strip=1&q=cache:https%3A%2F%2Fgithub.com%2FMARKETProtocol%2FMARKET.js%2Fissues%2F14) @MARKETProtocol work on their javascript library [through a bounty on gitcoin](https://gitcoin.co/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't believe I've never seen this (archived copy of Google cache where archive doesn't have bare URL) before. Nice!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inspiration in desperation :-D

@mlinksva mlinksva merged commit 9622af7 into github:master Oct 30, 2018
@katrinleinweber katrinleinweber deleted the secure-links branch October 30, 2018 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants