Init #1
Merged
Init #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koddsson
commented
Apr 16, 2019
Contributor
Author
|
cc/ @github/web-systems |
keithamus
reviewed
Apr 23, 2019
Co-Authored-By: David Graham <dgraham@github.com>
Co-Authored-By: David Graham <dgraham@github.com>
Co-Authored-By: David Graham <dgraham@github.com>
Co-Authored-By: David Graham <dgraham@github.com>
koddsson
commented
May 10, 2019
| "plugins": [ | ||
| ["@babel/plugin-transform-modules-umd", { | ||
| "globals": { | ||
| "selector-set": "SelectorSet" |
Contributor
Author
There was a problem hiding this comment.
The UMD build was looking for selectorSet in global but in the selector-set UMD build the global is set to SelectorSet:
https://github.com/josh/selector-set/blob/master/selector-set.js#L7
koddsson
commented
May 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty much lifted from
github/githubbut you can see the only difference in299cf78 where I add the ability to hook into the HTML response so we can do some nonce security checks with
html-safe.js. I'm not a big fan of the approach but I'm unsure on what else to do in order to be able to stop throw if there is a mismatch and not havehtml-safe.jslive in this repo.I've been told that we don't need
html-safe.jsanymore since we are supporting a lot newer browsers that don't have previous security issues as well as a lot stricter CSP that make thehtml-safe.jschecking not needed any more.Ref: https://github.com/github/web-systems/issues/200