This repository was archived by the owner on Mar 13, 2019. It is now read-only.
Re-tool the ActiveRecord aspect of this library to be strict #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change changes from a Dump-Everything default to a Dump-Nothing. Now, each ActiveRecord model that should be dumped needs to be flagged as such `replicate_enable`, each of that model's attributes, outside of the primary key, needs to be explicitly mentioned, and every association that should be included in a dump needs to be explicitly mentioned.
jasonroelofs
force-pushed
the
restrict-by-default
branch
from
6c2e9f1 to
0ab4243
Compare
Also with the significant breaking changes made, lets bump us up to v2.
As we now heavily restrict from the dumping side, loading can assume that the received data is good and can be pushed verbatim into the database. The only exception is we still have to handle id replication and natural keys.
jasonroelofs
force-pushed
the
restrict-by-default
branch
from
dfa138b to
8ae30f5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change changes from a Dump-Everything default to a Dump-Nothing.
Now, each ActiveRecord model that should be dumped needs to be flagged
as such
replicate_enable, each of that model's attributes, outside ofthe primary key, needs to be explicitly mentioned, and every association
that should be included in a dump needs to be explicitly mentioned.