Skip to content

Conversation

@lindseywild
Copy link
Contributor

@lindseywild lindseywild commented Feb 21, 2025

Related to https://github.com/github/vuln-mgmt/issues/139190.

Updates nokogiri to fix security updates. To do this, we were required to update the Ruby version as well. I chose to go right to 3.2 since 3.1 is pretty old.

@lindseywild lindseywild marked this pull request as ready for review February 21, 2025 16:48
Copilot AI review requested due to automatic review settings February 21, 2025 16:48
@lindseywild lindseywild requested a review from a team as a code owner February 21, 2025 16:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR updates the Ruby version used in the GitHub Actions test workflow from '3.0' to '3.2' to support a necessary update to nokogiri for security improvements.

  • Update Ruby version in the test matrix to meet the requirements for the updated nokogiri dependency.

Reviewed Changes

File Description
.github/workflows/test.yml Updated the Ruby version in the test matrix from 3.0 to 3.2

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

Copy link
Contributor

@khiga8 khiga8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thank you!!!

I think requiring Ruby 3.2+ is more than fair since 3.2 was released in Dec '22 (source)!

@lindseywild lindseywild merged commit 641bb67 into main Feb 21, 2025
4 checks passed
@lindseywild lindseywild deleted the lw/update-nokogiri branch February 21, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants