Fix patch vs post of environment variables #717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
FYI @decyjphr @luvsaxena1 , another couple fixes for environment variables. |
klutchell
force-pushed
the
kyle/uppercase-env-vars
branch
5 times, most recently
from
d46d969 to
9692140
Compare
klutchell
changed the title
Contributor
Author
|
@decyjphr I rebased on your latest changes, thanks for applying the lint fixes! |
This boolean was reversed when filtering existing variables, so it consistently sent a POST request to existing vars. Signed-off-by: Kyle Harding <kyle@balena.io>
klutchell
force-pushed
the
kyle/uppercase-env-vars
branch
from
9692140 to
e79e222
Compare
Contributor
Author
|
Sorry to bother you again @decyjphr, but could we consider merging this small change with big impact? |
Contributor
Author
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This boolean was reversed when filtering existing variables,
so it consistently sent a POST request to existing vars.