Skip to content

Make MismatchError a base Exception #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zerowidth merged 3 commits into from
Sep 20, 2019
Merged

Make MismatchError a base Exception #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3463724
Add failing example illustrating behavior of MismatchError in bare re…
iamvery Sep 17, 2019
0b76afc
Make MismatchError a base Exception
iamvery Sep 16, 2019
ad48edc
Fix begin/rescue syntax for older rubies
iamvery Sep 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/scientist/experiment.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def self.new(name)
end

# A mismatch, raised when raise_on_mismatches is enabled.
class MismatchError < StandardError
class MismatchError < Exception
attr_reader :name, :result

def initialize(name, result)
Expand Down
14 changes: 14 additions & 0 deletions test/scientist/experiment_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,20 @@ def @ex.raised(op, exception)
assert_raises(Scientist::Experiment::MismatchError) { @ex.run }
end

it "allows MismatchError to bubble up through bare rescues" do
Fake.raise_on_mismatches = true
@ex.use { "control" }
@ex.try { "candidate" }
runner = -> {
begin
@ex.run
rescue
# StandardError handled
end
}
assert_raises(Scientist::Experiment::MismatchError) { runner.call }
end

describe "#raise_on_mismatches?" do
it "raises when there is a mismatch if the experiment instance's raise on mismatches is enabled" do
Fake.raise_on_mismatches = false
Expand Down