Move rescued types to a constant #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
johana-star
approved these changes
Aug 12, 2017
johana-star
left a comment
johana-star
left a comment
There was a problem hiding this comment.
Very clearly written, and a pretty elegant seam to use for customization.
|
👍 This seems like an excellent migration plan |
zerowidth
approved these changes
Aug 22, 2017
Contributor
zerowidth
left a comment
zerowidth
left a comment
There was a problem hiding this comment.
👍 makes sense to me. Good path for 2.0.0 too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses (but doesn't close) #60. Right now,
ObservationrescuesObjectwhen it calls a behavior block. This can be pretty surprising, especially if an unhandled signal or aSystemExitis raised inside the block.The patch introduces a
Scientist::Observation::RESCUESconstant with a value of[Exception]. This set of exceptions is used to rescue instead of a hardcodedObject. I think we should switch the default value to[StandardError]in 2.0.0, here's how to do it in the meantime:/cc @djrodgerspryor @strand
/cc @jesseplusplus, who doesn't show up in the reviewer list