Handle child/frame-src gracefully across different browsers and versions #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures it can be cached.
…pying child-src to frame-src.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #260
Add some basic smarts around handling the frame-src -> child-src transition. Configurations should use
child-srcinstead offrame-src.frame-srcis supplied, emit a warning.frame-srcandchild-srcare supplied, and the values are not equal, emit a warningchild-src, sendchild-src || frame-src.child-src, sendframe-src || child-src.This also (re)introduces version-specific UA sniffing and policy generation for firefox 46, the first version to support
child-srcand emit deprecation warnings aboutframe-src. Browsers after a certain version will be marked "transitional" and the original set will remain for supporting old browsers. Doing this for safari should follow a same route.