CodeQL queries for actions#254
Merged
xcorail merged 3 commits intogithub:mainfrom Jan 28, 2021
JarLob:patchy
Merged
Conversation
xcorail
approved these changes
Jan 28, 2021
| * @description Workflows triggered on `pull_request_target` have read/write tokens for the base repository and the access to secrets. | ||
| * By explicitly checking out and running the build script from a fork the untrusted code is running in an environment | ||
| * that is able to push to the base repository and to access secrets. | ||
| * @id java/actions/pull_request_target |
Contributor
There was a problem hiding this comment.
Why has this (and the other) query the id java/foo?
Contributor
Author
There was a problem hiding this comment.
Good catch. A proper pull request will be created shortly, this is just for the blog post.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.