Skip to content
This repository was archived by the owner on Apr 1, 2025. It is now read-only.

Conversation

@robrix
Copy link
Contributor

@robrix robrix commented Jun 6, 2019

I think we’re hitting a thing where different C compilers treat the -I parameter differently w.r.t. the choice to use <> or "" in includes in C files.

I think we’re hitting a thing where different C compilers treat the -I parameter differently w.r.t. the choice to use <> or "" in includes in C files.

(Hopefully) fixes #96.
@robrix robrix requested a review from a team June 6, 2019 21:39
@patrickt
Copy link
Contributor

patrickt commented Jun 6, 2019

Nope:

src/bridge.c:1:10: error:
     fatal error: 'tree_sitter/api.h' file not found
  |
1 | #include <tree_sitter/api.h>
  |          ^
#include <tree_sitter/api.h>
         ^~~~~~~~~~~~~~~~~~~

I have no idea what is going wrong.

@patrickt
Copy link
Contributor

I think #110 and its associated changes should fix this? We’re correctly copying all the required headers in the Cabal packages and whatnot.

@robrix
Copy link
Contributor Author

robrix commented Jun 11, 2019

@patrickt: I’m going to close this and tree-sitter/haskell-tree-sitter#120 out in that case.

@robrix robrix closed this Jun 11, 2019
@robrix robrix deleted the c-compilers-are-mean branch June 11, 2019 14:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cabal new-install fails to copy tree-sitter header files when packaging haskell-tree-sitter submodule

3 participants