This repository was archived by the owner on Apr 1, 2025. It is now read-only.
Detail patch-acceptance policy and process in CONTRIBUTING.md. #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 7, 2019 11:07
We owe it to outside contributors to be clear about the process involved in submitting a patch to Semantic, and the sad fact that we won't be able to accept every proposed change.
tclem
approved these changes
Jun 7, 2019
dcreager
reviewed
Jun 7, 2019
Contributor
dcreager
left a comment
dcreager
left a comment
There was a problem hiding this comment.
Mostly good, just one thing to possibly change. Interested in your thoughts on it
| - Keep your change as focused as possible. If there are multiple changes you would like to make that are not dependent upon each other, consider submitting them as separate pull requests. | ||
| - Write a [good commit message](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html). | ||
|
|
||
| Please be aware that contributions to Semantic may be sent through multiple cycles of code review—we are grateful for all community involvement, but because Semantic powers real systems, we must maintain a high standard of code quality. For reasons of compatibility with production Semantic uses within GitHub, we may also reject or require modifications to changes that would affect these systems. We may also reject patches that don't fit with our vision of the project; should this be the case, we encourage you to start your own fork, as a healthy fork ecosystem is a sign of a robust community with varying requirements. |
Contributor
There was a problem hiding this comment.
“may be sent through” -> “may go through”
“production Semantic uses within” -> “production uses of Semantic within”
Contributor
There was a problem hiding this comment.
Not sure about explicitly encouraging forks. How about just “when this happens, we will be clear about our rationale”?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We owe it to outside contributors to be clear about the process
involved in submitting a patch to Semantic, and the sad fact that we
won't be able to accept every proposed change.