Skip to content
This repository was archived by the owner on Apr 1, 2025. It is now read-only.

Detail patch-acceptance policy and process in CONTRIBUTING.md. #105

Merged
merged 3 commits into from
Jun 7, 2019
Merged

Detail patch-acceptance policy and process in CONTRIBUTING.md. #105

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a970f14
Detail patch-acceptance policy and process in CONTRIBUTING.md.
Jun 7, 2019
f169c67
Tighten up language.
Jun 7, 2019
c683733
Merge branch 'master' into update-contributing
Jun 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ Here are a few things you can do that will increase the likelihood of your pull
- Keep your change as focused as possible. If there are multiple changes you would like to make that are not dependent upon each other, consider submitting them as separate pull requests.
- Write a [good commit message](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html).

Please be aware that contributions to Semantic may be sent through multiple cycles of code review—we are grateful for all community involvement, but because Semantic powers real systems, we must maintain a high standard of code quality. For reasons of compatibility with production Semantic uses within GitHub, we may also reject or require modifications to changes that would affect these systems. We may also reject patches that don't fit with our vision of the project; should this be the case, we encourage you to start your own fork, as a healthy fork ecosystem is a sign of a robust community with varying requirements.
Copy link
Contributor

@dcreager dcreager Jun 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“may be sent through” -> “may go through”

“production Semantic uses within” -> “production uses of Semantic within”

Copy link
Contributor

@dcreager dcreager Jun 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about explicitly encouraging forks. How about just “when this happens, we will be clear about our rationale”?


## Resources

- [How to Contribute to Open Source](https://opensource.guide/how-to-contribute/)
Expand Down