This repository was archived by the owner on Apr 1, 2025. It is now read-only.
Fix warnings in tests #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 [-Wunused-matches] 7 [-Wmissing-export-lists] 6 [-Wunused-imports] 5 [-Wmissing-signatures] 2 [-Wincomplete-uni-patterns] 1 [-Wunused-top-binds] 1 [-Wtype-defaults]
robrix
approved these changes
Jun 15, 2019
Contributor
robrix
left a comment
robrix
left a comment
There was a problem hiding this comment.
Great work; thank you so much!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #149
This should fix the majority of ghc warnings in tests.
Before this PR:
After this PR 2 just warnings remain, which I deliberately skipped:
1 [-Wunused-top-binds]- saying liftCons5 is unused. I could have deleted it, but I think it's better to keep it to maintain api "continuity" (liftCons1, liftCons2, etc.)1 [-Wmissing-signatures]- saying this crazy thing doesn't have type signature. I failed to assemble type for that and didn't want to copy the "raw" type from the warning to the souce code 😄