This repository was archived by the owner on Apr 1, 2025. It is now read-only.
Add language detailing policy re. PR approvals/change requests. #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've seen some members of the public come in and leave distracting reviews on our pull requests. This patch adds a clause to our contributing documentation that outlines why we don't want people to continue doing this.
dcreager
reviewed
Jun 17, 2019
| - Keep your change as focused as possible. If there are multiple changes you would like to make that are not dependent upon each other, consider submitting them as separate pull requests. | ||
| - Write a [good commit message](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html). | ||
|
|
||
| Unless you are a member of the Semantic team or a code owner, we ask that you refrain from leaving approvals or change requests on in-progress pull requests, as spurious reviews make it difficult to discern which patches are truly ready for integration. |
Contributor
There was a problem hiding this comment.
This should go up in the top-level Contributing section, not here. This section is about submitting a PR, which we definitely want anyone and everyone to feel comfortable doing!
How about the following as a new ¶ 2:
Suggested change
| Unless you are a member of the Semantic team or a code owner, we ask that you refrain from leaving approvals or change requests on in-progress pull requests, as spurious reviews make it difficult to discern which patches are truly ready for integration. | |
| We're happy to accept code and documentation contributions. And please feel free to open issues suggesting new features, asking questions about how things work, or generally about what we're trying to accomplish! **However**, we are not opening up the code review process to the public. PRs should _only_ be reviewed by one of the project maintainers. Therefore, we ask that you refrain from leaving approvals or change requests on in-progress pull requests, as spurious reviews make it difficult to discern which patches are truly ready for integration. |
aymannadeem
reviewed
Jun 17, 2019
|
|
||
| Hi there! We're thrilled that you'd like to contribute to this project. Your help is essential for keeping it great. | ||
|
|
||
| We're happy to accept code and documentation contributions, as well as issues suggesting new features, asking questions about how things work, or generally about what we're trying to accomplish! However, we are not opening up the code review process to the public. PRs should _only_ be reviewed by one of the project maintainers. Therefore, we ask that you refrain from leaving approvals or change requests on in-progress pull requests, as spurious reviews make it difficult to discern which patches are truly ready for integration. |
Contributor
There was a problem hiding this comment.
Not sure if this would sound too terse, but having a small heading "Code review process is not open to the public" might boost the signal
aymannadeem
approved these changes
Jun 17, 2019
Contributor
aymannadeem
left a comment
aymannadeem
left a comment
There was a problem hiding this comment.
lgtm barring @dcreager's suggestions!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen some members of the public come in and leave distracting
reviews on our pull requests. This patch adds a clause to our
contributing documentation that outlines why we don't want people to
continue doing this.