This repository was archived by the owner on Apr 1, 2025. It is now read-only.
Include vertex IDs in JSON graph output and fix their format. #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in #189, the `edges` field of JSON graph output refers to information not reflected in the rest of the output, specifically the vertex IDs. This patch adds that information to the `ToJSON` instance for `ControlFlowVertex`. It also includes a `toEncoding` instance for a free speed boost. During this patch, I realized that, because `hash` tends to return a large number (since `Int` is 64-bit), we may run into errors when decoding JSON. One example hash is `3500157981503982114`; passing that to a JS engine's `Number.isSafeInteger` function returns false. The correct thing to do here is return ids as strings, which I have done. This is backwards-incompatible, but since this information was never properly exposed, the impact is negligable.
Contributor
Author
|
Fixes #189. |
robrix
approved these changes
Jul 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #189, the
edgesfield of JSON graph output refers toinformation not reflected in the rest of the output, specifically the
vertex IDs. This patch adds that information to the
ToJSONinstancefor
ControlFlowVertex. It also includes atoEncodinginstance fora free speed boost.
During this patch, I realized that, because
hashtends to return alarge number (since
Intis 64-bit), we may run into errors whendecoding JSON. One example hash is
3500157981503982114; passing thatto a JS engine's
Number.isSafeIntegerfunction returns false. Thecorrect thing to do here is return ids as strings, which I have done.
This is backwards-incompatible, but since this information was never
properly exposed, the impact is negligable.