This repository was archived by the owner on Apr 1, 2025. It is now read-only.
Factor annotations out of Core #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robrix
commented
Jul 29, 2019
| stripAnnotations (Term t) | ||
| | Just c <- prj t, Ann _ b <- c = stripAnnotations b | ||
| | otherwise = Term (hmap stripAnnotations t) | ||
| stripAnnotations :: (HFunctor sig, forall g . Functor g => Functor (sig g)) => Term (Ann :+: sig) a -> Term sig a |
Contributor
Author
There was a problem hiding this comment.
Now the type of stripAnnotations guarantees that there aren’t any present.
| -- * Parsers (corresponding to EBNF) | ||
|
|
||
| core :: (TokenParsing m, Monad m) => m (Term Core User) | ||
| core :: (TokenParsing m, Carrier sig t, Member Core sig, Monad m) => m (t User) |
Contributor
Author
There was a problem hiding this comment.
Eventually we can (and should) generate annotations for parsed terms as well.
6 tasks
robrix
changed the base branch from
sequence-values-in-the-abstract-domain
to
master
patrickt
approved these changes
Aug 6, 2019
Contributor
patrickt
left a comment
patrickt
left a comment
There was a problem hiding this comment.
Love this—such a great exhibition for why the effects + syntax distinction is artificial.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits an
Anntype out ofCore, mostly as housekeeping but also to demonstrate sums of strongly-typed syntax.