Skip to content

Replace local file ref with workspace #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonrclark merged 1 commit into from
May 6, 2025
Merged

Replace local file ref with workspace #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .devcontainer/onCreate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ sudo mv ./spark-sdk-dist/proxy.js /usr/local/bin/proxy.js

tar -xzf ./spark-sdk-dist/spark-tools.tgz

mkdir -p /workspaces/spark-tools
sudo mv ./package/* /workspaces/spark-tools
mkdir -p /workspaces/spark-template/packages/spark-tools
sudo mv ./package/* /workspaces/spark-template/packages/spark-tools
Comment on lines +41 to +42
Copy link

Copilot AI May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Hardcoding the workspace path with the repository name (spark-template) can break if the repo is renamed. Consider deriving the path dynamically (e.g., using $PWD or an environment variable) to improve portability.

Suggested change
mkdir -p /workspaces/spark-template/packages/spark-tools
sudo mv ./package/* /workspaces/spark-template/packages/spark-tools
mkdir -p "$PWD/packages/spark-tools"
sudo mv ./package/* "$PWD/packages/spark-tools"

Copilot uses AI. Check for mistakes.
sudo rmdir ./package

sudo mv spark-sdk-dist/gh-spark-cli /usr/local/bin/
Expand Down
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ dist-ssr

.env
**/agent-eval-report*
.spark-tools
packages
7 changes: 6 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"preview": "vite preview"
},
"dependencies": {
"@github/spark": "file:../spark-tools",
"@github/spark": "0.0.1",
"@heroicons/react": "^2.2.0",
"@hookform/resolvers": "^4.1.3",
"@octokit/core": "^6.1.4",
Expand Down Expand Up @@ -87,5 +87,10 @@
"typescript": "~5.7.2",
"typescript-eslint": "^8.25.0",
"vite": "^6.2.0"
},
"workspaces": {
Copy link

Copilot AI May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using workspaces in package.json requires setting "private": true at the root, otherwise npm will prevent installation. Please add "private": true alongside your workspace config.

Copilot uses AI. Check for mistakes.
"packages": [
"packages/*"
]
}
}