Set file-syncer to run from spark-template#46
Merged
jasonrclark merged 1 commit intomainfrom May 21, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures the spark-file-syncer process always starts in the spark-template directory by explicitly setting its working directory.
- Adds a
directorydirective to the Supervisor config forspark-file-syncer. - Removes reliance on the
GITHUB_REPOSITORYlookup by hardcoding the start path.
Comments suppressed due to low confidence (1)
.devcontainer/spark.conf:36
- [nitpick] Indent the
directorydirective to match the indentation level of the other program settings (e.g., two spaces) for consistent formatting.
directory=/workspaces/spark-template
salvador-barboza
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards https://github.com/github/spark/issues/823
https://github.com/github/workbench-sdk/pull/279 removes our lookup on the
GITHUB_REPOSITORY(which plays badly when export repos) so we need to be strict about where we normally start the file syncer running.