Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces a hardcoded source alias with a dynamic one driven by an environment variable, allowing tests to override the project root.
- Imported
resolvefrom thepathmodule and introduced aprojectRootconstant with a fallback. - Changed the alias for
'@'toresolve(projectRoot, 'src').
Comments suppressed due to low confidence (1)
vite.config.ts:19
- [nitpick] The name
projectRootimplies the workspace root but is used to resolve the source folder. Consider renaming it tosourceRootorsrcPathfor clearer intent.
const projectRoot = process.env.PROJECT_ROOT || "/workspaces/spark-template/src"
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need a dynamic alias for tests to be able to build for tests etc.