Hydrate repo from remote #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds support for hydrating the repository from a remote snapshot URL and ensures project dependencies are installed in the devcontainer.
- Introduce a condition to run
hydrate.shin the background whenSNAPSHOT_SAS_URLis provided. - Log hydration output to
hydration.login the workspace. - Append
npm iat the end of the startup script to install dependencies.
.devcontainer/postStartCommand.sh
Outdated
| # Check if SNAPSHOT_SAS_URL was passed, if so run hydrate.sh in background | ||
| if [ -n "$SNAPSHOT_SAS_URL" ]; then | ||
| WORKSPACE_DIR="/workspaces/spark-template" | ||
| SAS_URI="$SNAPSHOT_SAS_URL" /usr/local/bin/hydrate.sh $WORKSPACE_DIR > $WORKSPACE_DIR/hydration.log 2>&1 & |
There was a problem hiding this comment.
Quote the redirection path to handle potential spaces in the workspace directory, e.g., > "$WORKSPACE_DIR/hydration.log".
Suggested change
| SAS_URI="$SNAPSHOT_SAS_URL" /usr/local/bin/hydrate.sh $WORKSPACE_DIR > $WORKSPACE_DIR/hydration.log 2>&1 & | |
| SAS_URI="$SNAPSHOT_SAS_URL" /usr/local/bin/hydrate.sh $WORKSPACE_DIR > "$WORKSPACE_DIR/hydration.log" 2>&1 & |
.devcontainer/postStartCommand.sh
Outdated
| supervisorctl reread | ||
| supervisorctl update | ||
|
|
||
| npm i |
There was a problem hiding this comment.
Consider switching to npm ci for deterministic installs and ensure it runs in the project root, e.g., cd $WORKSPACE_DIR && npm ci.
Suggested change
| npm i | |
| WORKSPACE_DIR="/workspaces/spark-template" | |
| cd $WORKSPACE_DIR && npm ci |
| "$SCRIPT_DIR/refreshTools.sh" | ||
|
|
||
| # Check if SNAPSHOT_SAS_URL was passed, if so run hydrate.sh in background | ||
| if [ -n "$SNAPSHOT_SAS_URL" ]; then |
Collaborator
There was a problem hiding this comment.
We will need some indicator to know when this is finished
alexagillman
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.