Skip to content

make c ignores consistent with c++#1747

Merged
mnriem merged 1 commit intogithub:mainfrom
dhilipkumars:implement-c-ignore-patterns
Mar 4, 2026
Merged

make c ignores consistent with c++#1747
mnriem merged 1 commit intogithub:mainfrom
dhilipkumars:implement-c-ignore-patterns

Conversation

@dhilipkumars
Copy link
Contributor

Description

remembered this after we merged this yesterday #1558

tiny update to keep the ignores consistent with c++ ones.

Testing

  • Tested locally with uv run specify --help
  • Ran existing tests with uv sync && uv run pytest
  • Tested with a sample project (if applicable)

AI Disclosure

  • I did not use AI assistance for this contribution
  • I did use AI assistance (describe below)

Copilot AI review requested due to automatic review settings March 3, 2026 23:22
@dhilipkumars dhilipkumars requested a review from mnriem as a code owner March 3, 2026 23:22
@dhilipkumars
Copy link
Contributor Author

cc: @zaheer15351 and @mnriem

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns the C ignore-pattern guidance in the implementation command template with the existing C++ guidance (per the follow-up to #1558), ensuring Windows build artifacts are handled consistently in generated/verified ignore files.

Changes:

  • Add *.dll to the recommended C ignore patterns to match C++.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mnriem mnriem merged commit c84756b into github:main Mar 4, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants