Skip to content

Add support for SPECKIT_WORKFLOW_RUN_ID override#2742

Merged
mnriem merged 3 commits into
mainfrom
copilot/support-speckit-workflow-run-id-override
May 29, 2026
Merged

Add support for SPECKIT_WORKFLOW_RUN_ID override#2742
mnriem merged 3 commits into
mainfrom
copilot/support-speckit-workflow-run-id-override

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 28, 2026

Implements support for overriding workflow run IDs via the SPECKIT_WORKFLOW_RUN_ID environment variable.


This section details on the original issue you should resolve

<issue_title>Support SPECKIT_WORKFLOW_RUN_ID override</issue_title>
<issue_description></issue_description>

Comments on the Issue (you are @copilot in this section)

What changed

  • Added SPECKIT_WORKFLOW_RUN_ID handling in workflow execution so it is used when no explicit run_id argument is provided.
  • Preserved precedence so an explicitly passed run_id still overrides the environment variable.
  • Added focused tests covering:
    • env-based run ID override behavior
    • explicit run_id precedence over env override

Validation

  • ruff check src passed
  • Targeted workflow tests for run ID behavior passed
  • Parallel validation completed (Code Review + CodeQL), with no security findings

Copilot AI self-assigned this May 28, 2026
Copilot AI review requested due to automatic review settings May 28, 2026 19:23
Copilot AI review requested due to automatic review settings May 28, 2026 19:23
Copilot AI linked an issue May 28, 2026 that may be closed by this pull request
Copilot AI requested a review from mnriem May 28, 2026 19:24
Copy link
Copy Markdown
Collaborator

@mnriem mnriem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Please complete the work

Copilot AI requested review from Copilot and removed request for Copilot May 28, 2026 21:25
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 28, 2026

@copilot Please complete the work

Completed in 6c5cdc8. This adds SPECKIT_WORKFLOW_RUN_ID as a run-id override when no explicit run_id is passed, plus focused tests for env override behavior and explicit run_id precedence.

Copilot AI changed the title [WIP] Add support for SPECKIT_WORKFLOW_RUN_ID override Add support for SPECKIT_WORKFLOW_RUN_ID override May 28, 2026
Copilot finished work on behalf of mnriem May 28, 2026 21:26
Copilot AI requested a review from mnriem May 28, 2026 21:26
Copy link
Copy Markdown
Collaborator

@mnriem mnriem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot So the workflow CAN be passed in, but if not passed in one is still generated? Correct? And the run id is available in the context of a step, correct?

@mnriem mnriem marked this pull request as ready for review May 29, 2026 14:14
Copilot AI review requested due to automatic review settings May 29, 2026 14:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an environment-variable override for workflow run IDs so operators/CI can force a stable run_id without changing call sites, while preserving explicit run_id argument precedence.

Changes:

  • Read SPECKIT_WORKFLOW_RUN_ID inside WorkflowEngine.execute() when run_id is not provided.
  • Preserve precedence: an explicitly passed run_id continues to win over the environment override.
  • Add tests for env override behavior and explicit-arg precedence.
Show a summary per file
File Description
src/specify_cli/workflows/engine.py Applies SPECKIT_WORKFLOW_RUN_ID as the effective run id when run_id is None.
tests/test_workflows.py Adds regression tests asserting env override behavior and precedence rules.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 2

Comment thread src/specify_cli/workflows/engine.py
Comment thread tests/test_workflows.py Outdated
Copilot finished work on behalf of mnriem May 29, 2026 14:34
Copilot AI requested a review from mnriem May 29, 2026 14:34
@mnriem mnriem requested a review from Copilot May 29, 2026 14:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 0 new

@mnriem mnriem merged commit cc3d828 into main May 29, 2026
13 checks passed
@mnriem mnriem deleted the copilot/support-speckit-workflow-run-id-override branch May 29, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support SPECKIT_WORKFLOW_RUN_ID override

3 participants