Add confirmation prompt for URL-based extension installs#2745
Merged
Conversation
Display a yellow warning panel and default-deny [y/N] prompt when installing extensions via --from <url>, since this bypasses the catalog trust boundary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2744
Summary
specify extension add <name> --from <url>bypasses the catalog trust boundary. The user's configured extension catalogs are the primary mechanism for establishing trust in extension sources — installing from an arbitrary URL sidesteps that entirely.Previously the CLI printed a yellow warning and proceeded silently. This PR adds a default-deny confirmation prompt so the user must consciously acknowledge they are leaving the trusted catalog path.
Changes
src/specify_cli/__init__.py— Replace the silent warning with:typer.confirm()prompt defaulting to No ([y/N])Context
--from <url>install_allowedpolicy enforcedThe catalog path doesn't need a prompt because the user already established trust by adding that catalog to their config.